Subgraph composition : Add Integration Tests #5595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
force-pushed
the
subgraph-composition-base
branch
4 times, most recently
from
db03c31 to
3323e79
Compare
zorancv
changed the base branch from
master
to
subgraph-composition-intermediate
zorancv
force-pushed
the
subgraph-composition-intermediate
branch
from
e288d87 to
17a4120
Compare
zorancv
force-pushed
the
subgraph-composition-base
branch
from
c2e1ae2 to
7aacb63
Compare
incrypto32
force-pushed
the
subgraph-composition-intermediate
branch
3 times, most recently
from
10725c2 to
3afd1c6
Compare
zorancv
changed the base branch from
subgraph-composition-intermediate
to
zoran/subgraph-datasource
incrypto32
force-pushed
the
zoran/subgraph-datasource
branch
from
10725c2 to
0a89a4e
Compare
incrypto32
force-pushed
the
subgraph-composition-base
branch
from
7aacb63 to
fd2fdd4
Compare
incrypto32
changed the title
lutter
reviewed
Nov 12, 2024
zorancv
force-pushed
the
zoran/subgraph-datasource
branch
from
8ce342f to
9acd51e
Compare
zorancv
force-pushed
the
zoran/subgraph-datasource
branch
5 times, most recently
from
6a47d26 to
0d7e4d5
Compare
zorancv
force-pushed
the
subgraph-composition-base
branch
2 times, most recently
from
e96cbba to
fd2fdd4
Compare
incrypto32
force-pushed
the
subgraph-composition-base
branch
from
fd2fdd4 to
8f4563b
Compare
zorancv
force-pushed
the
subgraph-composition-base
branch
2 times, most recently
from
9f70d9a to
6016a3e
Compare
incrypto32
force-pushed
the
subgraph-composition-base
branch
from
6016a3e to
9f70d9a
Compare
zorancv
force-pushed
the
zoran/subgraph-datasource
branch
from
81fb399 to
70ca609
Compare
zorancv
force-pushed
the
subgraph-composition-base
branch
2 times, most recently
from
536ae0a to
3ac0c1a
Compare
lutter
approved these changes
Dec 20, 2024
| test: force_boxed(test), | ||
| source_subgraph: Some(source_subgraph.to_string()), | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Instead of duplicating Self::new with that ugly force_boxed, why not just use
{
let mut test_case = Self::new(..);
test_case.source_subgraph = ...;
test_case
}
incrypto32
force-pushed
the
zoran/subgraph-datasource
branch
2 times, most recently
from
b5af690 to
d2f6352
Compare
incrypto32
force-pushed
the
subgraph-composition-base
branch
from
3ac0c1a to
92aca24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch is intended to be a base for further PRs of the subgraph composition feature. It adds integration tests.